Wrap render function in SWIG threads macro, to disable Python GIL #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amended after running black formatting
|
Ah, files are re-formated by black. |
Add build instructions, update c library url. SWIG build has '-threads' argument for recent GIL patch.
|
Thanks for putting in the effort to PR this. I don't use WS281x pixels as much as I did when I first adopted this library, so I'm pressed for time and incentive to give it a proper test. Any drive-by volunteers who fire up this code and find the changes useful, your comments would be very helpful! |
|
This patch was designed to make its use optional, so in theory should be the same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at issue #98 -- a new wrapper function to disable Python GIL during rendering.
It-Works-For-Me...
This is so unrelated Python threads can run while ws2812 does its thing. I'm not trying to imply rpi_ws281x is thread-safe.
Not sure why the SWIG-generated files have different formatting than what was there.
I used "swig -python -threads".